-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Re-enable ChromeOS testing #6559
Conversation
Incremental code coverage: 100.00% |
I don't think our lab ChromeOS device is alive right now. |
# Conflicts: # .github/workflows/shaka-bot-commands/command-test.sh
Can you start it so we can adjust the tests and add it to the normal cycle? Thanks! |
I will work on that later today if I can. I need to go into the lab, update the device, and check that ChromeOS WebDriver Server is still functional. We haven't used it in a long time, so it may not be any more. When the device is on and updated, and WebDriver Server is working, I need to add it to the Shaka Lab Node config. Then it should be available to CI again. |
# Conflicts: # build/shaka-lab.yaml
This reverts commit ead848c.
@shaka-bot test |
@avelad: Lab tests started with arguments:
|
I had already updated and fixed the ChromeOS device in our lab. However, some time later, it seems to have rebooted or auto-updated and in the process, SSH was disabled. The setup process is meant to keep SSH enabled across updates and reboots, but it's not working and needs to be fixed. |
Only for ChromeOS or for all the lab? |
I was referring to the setup process for ChromeOS in the lab. After some more digging, I discovered that I was misremembering. Before Generic WebDriver Server, we had a much more complicated system where we explicitly disabled auto-updates, and had to periodically run a custom tool that would check for updates, install those updates, then modify them to enable SSH and a read-write root partition before rebooting. And it failed a lot. The docs for Generic WebDriver Server say:
So I'm working on a solution to that. I have an idea that may work, but I haven't been able to test it yet. There's a feature in the OS now called "DLC" that may allow us to install an extra piece of software that survives updates and is reapplied after each one. If I can use that mechanism to enable SSH, and incorporate that into the setup instructions, ChromeOS WebDriver Server, which uses SSH to control the device, should continue to function across updates. |
@joeyparrish any update? |
Any eta @joeyparrish ? Should I close it? |
It didn't work. I don't have any new ideas at the moment. |
No description provided.